Formatter: Fix formatting `<% else %>` in inline mode by marcoroth · Pull Request #809 · marcoroth/herb

marcoroth · 2025-11-08T05:06:05Z

This pull request fixes a bug in the formatter, where we accidentally visited the end_node twice, instead of the subsequent node.

This following document

<span>
  <% if valid? %>
    Valid
  <% else %>
    Invalid
  <% end %>
</span>

was previously formatter to:

<span><% if valid? %>Valid<% end %><% end %></span>

Now it gets correctly formatted as:

<span><% if valid? %>Valid<% else %>Invalid<% end %></span>

Resolves #789

tk0miya · 2025-11-09T05:00:22Z

Thank you for the quick fix!

Formatter: Fix formatting <% else %> in inline mode

29c4e10

github-actions Bot added formatter typescript labels Nov 8, 2025

marcoroth added the bug Something isn't working label Nov 8, 2025

Add more tests

c1260a8

marcoroth merged commit 8d9ed54 into main Nov 8, 2025
12 checks passed

marcoroth deleted the foramtter-conditional-inline-mode branch November 8, 2025 18:15

Provide feedback